Feature: allow parsing webhook with event name of type str #123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling the
parse
functions for webhooks, we don't always control where thename
parameter comes from.In my case, I retrieve it from a HTTP request's header and the type is simply
str
:And pyright complains with the following:
error: Type of "event" is unknown (reportUnknownVariableType)
error: No overloads for "parse" match the provided arguments (reportCallIssue)
However, since
parse
andparse_obj
check forname
to be part ofVALID_EVENT_NAMES
it looks safe to me to allow for plainstr
to be passed.Let me know what you think.