-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add caching for HTTP responses #62
Conversation
We can add a |
We could inject |
@karpetrosyan hello, i have encountered some errors when testing, it seems is caused by this pr. The transport socket is not closed after httpx client closed. The GC throws the error when collect the transport. https://github.com/karpetrosyan/hishel/blob/0948f9e59e123f2703e199b844fcc394696b5921/hishel/_async/_transports.py#L235-L236 I don't know if this is as designed for hishel? |
Hi! |
Hishel v0.0.21 is out https://pypi.org/project/hishel/! Thanks for contribution |
Closes #61
Adds RFC9111 HTTP caching, which caches responses that the server suggests reusing.
If we want to provide a way to disable caching, perhaps we should add something like
http_cache
boolean to theGitHub
class?