Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: fix cache and cycle ref issue #81

Merged
merged 3 commits into from
Jan 6, 2024
Merged

Bug: fix cache and cycle ref issue #81

merged 3 commits into from
Jan 6, 2024

Conversation

yanyongyu
Copy link
Owner

Use weakref to avoid cycle ref. This can improve the gc collection. Instance can be collected immediately after var release now.

Also fix #79 . Cache now depends on github instance weakref.

@yanyongyu yanyongyu added the bug Something isn't working label Jan 6, 2024
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8a381cb) 75.60% compared to head (f5612df) 75.60%.

Files Patch % Lines
githubkit/versions/rest.py 92.85% 1 Missing ⚠️
githubkit/versions/v2022_11_28/rest/__init__.py 85.71% 1 Missing ⚠️
githubkit/versions/v2022_11_28/rest/repos.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #81   +/-   ##
=======================================
  Coverage   75.60%   75.60%           
=======================================
  Files         541      541           
  Lines       59462    59482   +20     
=======================================
+ Hits        44957    44974   +17     
- Misses      14505    14508    +3     
Flag Coverage Δ
unittests 75.60% <89.28%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yanyongyu yanyongyu merged commit 469afbb into master Jan 6, 2024
19 checks passed
@yanyongyu yanyongyu deleted the fix/ref branch January 6, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Underlying HTTPX clients are shared among several GitHub instances
1 participant