feat: add riscv64 and loong64 to known archs
#62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hack3ric
added a commit
to hack3ric/pkg
that referenced
this pull request
Nov 20, 2024
riscv64 and loong64 have unofficial builds at https://unofficial-builds.nodejs.org and can be used in SEA build. This is in conjunction with yao-pkg/pkg-fetch#62.
|
@hack3ric Why do you need this change? In order to allow fetch to build nodejs patches? Because I will not create patches for this archs, if your goal is to use pkg SEA this change is not needed as SEA doesn't use fetch |
|
Just like previously included ppc64 and s390x, at least allow it to build from source on these architectures, not limited to SEA. SEA still needs to read That CI part is just a BTW. |
hack3ric
added a commit
to hack3ric/pkg
that referenced
this pull request
Nov 20, 2024
riscv64 and loong64 have unofficial builds at https://unofficial-builds.nodejs.org and can be used in SEA build. This is in conjunction with yao-pkg/pkg-fetch#62.
hack3ric
added a commit
to hack3ric/pkg
that referenced
this pull request
Nov 20, 2024
riscv64 and loong64 have unofficial builds at https://unofficial-builds.nodejs.org and can be used in SEA build. This is in conjunction with yao-pkg/pkg-fetch#62.
robertsLando
changed the title
riscv64 and loong64 to known archs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are two architecture that Node.js supports (however no official prebuilts; unofficial prebuilts are in https://unofficial-builds.nodejs.org/download/release/). Include them will at least allow us to build patch Node on those platforms. However to build in CI we probably need to update Dockerfile.linuxcross to at least GCC 13. I am not too sure if this affects compatibility.