Cannot call nextSibling of null
#290
Comments
|
@hbrysiewicz thanks for reporting this. I've reproduced it and have confirmed your workaround. I'm equally at a loss about what is going on. |
jlblcc
added a commit
to jlblcc/mdEditor
that referenced
this issue
Mar 4, 2020
Fix bug when closing the modal, see yapplabs/ember-modal-dialog#290. Apparently, a `tagName` is required. Refactored to remove dependency on md-button-modal. Closes adiwg#379.
jlblcc
added a commit
to adiwg/mdEditor
that referenced
this issue
Mar 18, 2020
Fix bug when closing the modal, see yapplabs/ember-modal-dialog#290. Apparently, a `tagName` is required. Refactored to remove dependency on md-button-modal. Closes #379.
jlblcc
added a commit
to adiwg/mdEditor
that referenced
this issue
Mar 18, 2020
Fix bug when closing the modal, see yapplabs/ember-modal-dialog#290. Apparently, a `tagName` is required. Refactored to remove dependency on md-button-modal. Closes #379.
hmaier-fws
added a commit
to adiwg/mdEditor
that referenced
this issue
Jan 19, 2023
…ch (#514) * Fix taxon component and test * Bump version to 0.10.0.rc1 * Fix taxon test * Upgrade model-dialog Use closures instead of sendAction. * Fix settings save action * Re-factor tree-branch to use proxy ember-drag-drop now proxies the draggable-object. So we need to "unwrap" the object before using it. See mharris717/ember-drag-drop#159 * `propertyDidChange` method is deprecated in favor of 'notifyPropertyChange` See https://deprecations.emberjs.com/v3.x/#toc_use-notifypropertychange-instead-of-propertywillchange-and-propertydidchange * Replace references to Transition state Accessing state, queryParams or params on the Transition has been removed. See https://deprecations.emberjs.com/v3.x/#toc_transition-state * v0.10.0.rc2 * Replace references to Transition state Accessing state, queryParams or params on the Transition has been removed. See https://deprecations.emberjs.com/v3.x/#toc_transition-state * Added theme style guide Will compile to /styledoc/index.html Closes #364. * Remove ember-multiselect-checkboxes from dependencies * Updates from ember-modules-codemod Mainly formatting. See https://github.com/ember-codemods/ember-modules-codemod * Updates from es5-getter-ember-codemod See https://github.com/ember-codemods/es5-getter-ember-codemod. * Refactor to support md-toggle Global config values are not initialized in md-toggle instances. * Migrate Travis to bionic * Added jsconfig.json to .gitignore * Fix mispelled position label in contact show route Resolves: #362 * Fix metadataRepository title Added patch. Add test for repository and title values. Fixes #368. * Bump version to 0.10.0.rc3 * Changed title of "foreign keys attributes" - md-entity template array-table title was changed to foreign key - fixed integration test to reflect changes Resolves #278 * Fixed label name for entity attribute and domain item - new label for entity attribute is "attribute name" - new label for domain item is "domain item name" * Fixed corresponding test Closes #276 * Fixing failing md-associated/preview test * Revert "Fixing failing md-associated/preview test" Resolves #276 Resolves #278 Resolves #273 This reverts commit 490b264. * Fixing travis build failure Resolves #276 Resolves #273 Resolves #278 * Changed time in md-associate/preview test Resolves #273 Resolves #276 Resolves #278 * Validate the user is on specific route Resolves #350 * Passed md/indicator through md-entity Resolves #350 * Hack job Resolves #350 * Hacking the domain name Resolves #350 * Refactor md-indicator * Added reference text for sourceforge mailing list - added external link for access to soureforge mailing list Closes #375 * Update help - Add .external class to style external links. - Add link buttons to Help - Fix test Fixes #375. * Removed unused "find" method from @ember/test-helpers Resolves #375 * Created md-indicator component * Added ember-popover selector for specific styling * Temporary look at md-indicator component - setup on the md-object-table * Working with logic for md-indicator component * Test for md-indicator component * Validate the user is on specific route Resolves #350 * Passed md/indicator through md-entity Resolves #350 * Hack job Resolves #350 * Hacking the domain name Resolves #350 * Modified md-associated test for timezone Resolves #350 * Refactor md-indicator * Removed example md-indicators from md-entity Resolves #350 * Removed conditional syntax - removed span element that took up space if domain doesn't exist * Removed block usage from md-indicator test * Removed block usge for md-indicator/related test * Working on testing for md-indicator and md-indicator/related * Resolves #374 * Refactored md/indicator test - needs more work on the triggerEvent for hoover - skipped md/indicator/related test until clarification Resolves #350 * Refactored md-interpolate test Resolves #350 * Refactor tests - Improve dictionary helper - Update md-indicator, md-interpolate tests * Added popperContainer definition to init method * Refactored component.js for md-indicator/related - initialized 'md-indicator-related' className - added yuidoc comments * Refactored md-indicator/related template - removed repetitive code included in md-indicator component * Refactored test for md-indicator-related - still needs a way to test button click * Refactor indicator components Support event param. Fix tests. Closes #350. * Update docs Update yui-mdeditor-theme. * Update profile menu when profile titles are edited Closes #176. * Bump version, update CHANGELOG * Re-factor md-modal Fix bug when closing the modal, see yapplabs/ember-modal-dialog#290. Apparently, a `tagName` is required. Refactored to remove dependency on md-button-modal. Closes #379. * Add option to keep settings Optionally, keep the settings when clearing the cache. Refactored the template to use md-modal. Added a checkbox control for keeeping settings. Closes #257. * Update packages * Bump version * Update nodejs to v10 in travis * Refactor initial loading of records - Remove possible race condition by basing metadata associtation on modelName instead of index - load settings via service init Closes #382. * Ignore patches * Added local storage alert to app initialization - conditionally rendered if user is over local storage capacity Closes #157 * Added storage monitor service - service tracks local storage size and alerts user via flash message Closes #157 * Added storage monitor service to md-footer - gives user dynamic information on current storage capacity Closes #157 * Styles for app initialization storage monitor alert Closes #157 * Revert "Added storage monitor service to md-footer" This reverts commit 7eb95fe. * Added markup for storage monitor service in md-footer Closes #157 * Added storage monitor service to adapter - this will check local storage size before user updates records to ensure users aren't over limit Closes #157 * Utility used to calculate obect size Closes #157 * Offline first support Closes #381. * Offline first support Closes #381. * Replace SimpleMDE with EasyMDE Integrated directly into refactored md-markdown-area. Enables native spell checker. Removes dependency on ember-simplemde Closes #296. * Refactored alert message - removed dismiss button - created timeout to progress to app * Added yuidocs references * Refactored storage monitor critical message * Fixed all corresponding test for storage monitor Closes #157 * Fixed spelling in alert message * Re-factor md-modal Fix bug when closing the modal, see yapplabs/ember-modal-dialog#290. Apparently, a `tagName` is required. Refactored to remove dependency on md-button-modal. Closes #379. * Add option to keep settings Optionally, keep the settings when clearing the cache. Refactored the template to use md-modal. Added a checkbox control for keeeping settings. Closes #257. * Update packages * Bump version * Update nodejs to v10 in travis * Refactor initial loading of records - Remove possible race condition by basing metadata associtation on modelName instead of index - load settings via service init Closes #382. * Ignore patches * Offline first support Closes #381. * Revert "Offline first support" This reverts commit 3f630ca. * Revert "Ignore patches" This reverts commit 77c8415. * Revert "Refactor initial loading of records" This reverts commit e7425ce. * Revert "Update nodejs to v10 in travis" This reverts commit 8a4c6d2. * Revert "Bump version" This reverts commit 2a16f2b. * Revert "Update packages" This reverts commit 32f7807. * Revert "Add option to keep settings" This reverts commit 1c1c184. * Revert "Re-factor md-modal" This reverts commit 258b2c1. * Re-factor md-modal Fix bug when closing the modal, see yapplabs/ember-modal-dialog#290. Apparently, a `tagName` is required. Refactored to remove dependency on md-button-modal. Closes #379. * Add option to keep settings Optionally, keep the settings when clearing the cache. Refactored the template to use md-modal. Added a checkbox control for keeeping settings. Closes #257. * Update packages * Bump version * Update nodejs to v10 in travis * Refactor initial loading of records - Remove possible race condition by basing metadata associtation on modelName instead of index - load settings via service init Closes #382. * Ignore patches * Update packages, bump version to 0.11.0-dev * Changing the name of mdCalcStorage utility - changed name to md-object-size Closes #157 * Refactored md-footer indicator - changed button to plain text _ added tooltip descrbing what the indicator is Closes #157 * Removed "event" attribute used for testing * Fixed updateRecord() adapter - added error messaging that will resolve promise if user is over 5mb of local storage Closes #157 * Fixed updateRecord() adapter - added error messaging that will resolve promise if user is over 5mb of local storage Closes #157 * Refactored md-footer Closes #157 * Refactored mdObjectSize util Closes #157 * Refactored testing and working on initializer Closes #157 * Removed local storage check from adapter Close #157 * Added conditional logic to base.js - before save, logic will check local storage size is over threshold Closes #157 * Refactored mdfooter for local storage percent display Closes #157 * Added error catch to record route * Refactored mdfooter Closes #157 * Added custom messages for start and end time validators Closes #349 * Deleted logic in the initializer - removed local storage capacity message Closes #157 * Fixed spacing * Logic in the beforeModel hook - added logic that will push user to error route if storage is above capacity Closes #157 * Test and Refactorying * Test Closes #157 * Test 2 * Added settings service back in to resolve conflict Closes #157 * Refactored timePeriod enhancement -Cleaned up md-time-period validations code -Set global options message for md-date-range Closes #349 Closes #349 * Quick refactor on md-date-range Closes #349 * Deleted alert_boot.scss Closes #157 * Changed beforeModel hook logic to final state * Bump websocket-extensions from 0.1.3 to 0.1.4 Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot[bot] <support@github.com> * upgraded forward compatible packages - ajv, avj-errors, ember-autoresize will stay at current version and put on todo list * Updated forward ocmpatible packages v3.12.0...v3.20.2 * stage 1 codemods - removed DS from module imports - refactored "get()" into "this." - refactored test for dom assertions - minor eslint refactoring * fixed ember-cli-head package * installed dependecies for native class codemods * fixed ember-ajax * stage 1 codemods - routes converted to native classes - removed unused folder structures * reconfigured folder structure to align with pods * getting eslintrc ready for ember decorators and native class #415 * reverted ember-models-table to older version * stage 1 codemods - refactored md-models-table for native classes - used @classic decorator, couldn't use native classes due to ember-models-table * installed eslint and prettier for javascript files * stage 1 codemods - standalone components converted to native class synthax using @classic decorator * looking for different solution with eslint * linting * setup linting for javascript files and future typescript integration * fixed eslint for debounce errors * more changes to eslint * linting * - changed a tag to reflect possible functionality - angle bracket support Closes #216 * viewing dictionary locale not showing in view - fixed template.hbs to loop through dictionary.locale object and display each locale record - linting, native classes, and angle brackets where applied Closes #427 * - linting, native class conversion, angle bracket conversion * - working on depreceation messages * stage 1 codemods contact route converted - native class with @classic decorator - angle bracket notation - linting * stage 1 codemods contacts route converted - native class with @classic decorator - angle bracket notation - linting * stage 1 codemods dashboard route converted - native class with @classic decorator - angle bracket notation - linting * stage 1 codemods dictionaries route converted - native class with @classic decorator - angle bracket notation - linting * stage 1 codemods dictionary route converted - native class with @classic decorator - angle bracket notation - linting * stage 1 codemods error route converted - native class with @classic decorator - angle bracket notation - linting * stage 1 codemods export route converted - angle bracket notation - linting * stage 1 codemods help route converted - native class with @classic decorator - angle bracket notation - linting * stage 1 codemods import route converted - native class with @classic decorator - angle bracket notation - linting * stage 1 codemods not-found route converted - native class with @classic decorator - angle bracket notation - linting * stage 1 codemods publish route converted - native class with @classic decorator - angle bracket notation - linting * stage 1 codemods record route converted - native class with @classic decorator - angle bracket notation - linting * stage 1 codemods records route converted - native class with @classic decorator - angle bracket notation - linting * stage 1 codemods save route converted - native class with @classic decorator - angle bracket notation - linting * stage 1 codemods settings route converted - native class with @classic decorator - angle bracket notation - linting * stage 1 codemods translate route converted - native class with @classic decorator - angle bracket notation - linting * Bump acorn from 5.7.3 to 5.7.4 Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@5.7.3...5.7.4) Signed-off-by: dependabot[bot] <support@github.com> * Bump jquery from 3.4.1 to 3.5.1 Bumps [jquery](https://github.com/jquery/jquery) from 3.4.1 to 3.5.1. - [Release notes](https://github.com/jquery/jquery/releases) - [Commits](jquery/jquery@3.4.1...3.5.1) Signed-off-by: dependabot[bot] <support@github.com> * Bump lodash from 4.17.15 to 4.17.21 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.21) Signed-off-by: dependabot[bot] <support@github.com> * Bump ini from 1.3.5 to 1.3.8 Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.8) Signed-off-by: dependabot[bot] <support@github.com> * Bump http-proxy from 1.18.0 to 1.18.1 Bumps [http-proxy](https://github.com/http-party/node-http-proxy) from 1.18.0 to 1.18.1. - [Release notes](https://github.com/http-party/node-http-proxy/releases) - [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md) - [Commits](http-party/node-http-proxy@1.18.0...1.18.1) Signed-off-by: dependabot[bot] <support@github.com> * Bump socket.io from 2.3.0 to 2.4.1 Bumps [socket.io](https://github.com/socketio/socket.io) from 2.3.0 to 2.4.1. - [Release notes](https://github.com/socketio/socket.io/releases) - [Changelog](https://github.com/socketio/socket.io/blob/2.4.1/CHANGELOG.md) - [Commits](socketio/socket.io@2.3.0...2.4.1) Signed-off-by: dependabot[bot] <support@github.com> * stage 1 codemods all services/ converted - native class with @classic decorator - angle bracket notation - linting * stage 1 codemods - linting * - fixed dicitionary route and linting * clean up before development branch is merged * Adding resolutions value to package.json until update dependency. closes #437 * fixing merge conflicts * pushed forward compatible dependencies * Minor Update backward-compatible features * Major Update backward-incompatible updates * Minor Update backward-compatible features - 2 * 'pages etup' * setting up 3.26 * v3.20.2...v3.26.1 * setting some base themes with new fontawesome package * fixed scss usage of fontawesome * removed typescript from app build * Bump tmpl from 1.0.4 to 1.0.5 Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/daaku/nodejs-tmpl/releases) - [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5) --- updated-dependencies: - dependency-name: tmpl dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * upgrade forward-compatible packages * Minor update backward-compatible features * Minor Update backward-compatible features * Patch Update backward-compatible bug fixes * v3.26.1...v3.28.0 * "Moving app version back to v10.0 for better control of upgrade to ember 4.20" * "more fixes" * add nvmrc file for node version switching to local env * fixed folder structure and upgrade packages * fixed all deprecated computed values for CSs * roll back to find merge fault * Feature/external contact identifiers (#487) * Bump tmpl from 1.0.4 to 1.0.5 Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/daaku/nodejs-tmpl/releases) - [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5) --- updated-dependencies: - dependency-name: tmpl dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Bump codemirror from 5.44.0 to 5.65.4 Bumps [codemirror](https://github.com/codemirror/CodeMirror) from 5.44.0 to 5.65.4. - [Release notes](https://github.com/codemirror/CodeMirror/releases) - [Changelog](https://github.com/codemirror/CodeMirror/blob/master/CHANGELOG.md) - [Commits](codemirror/codemirror5@5.44.0...5.65.4) --- updated-dependencies: - dependency-name: codemirror dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Bump socket.io-parser from 3.3.0 to 3.3.2 Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 3.3.0 to 3.3.2. - [Release notes](https://github.com/socketio/socket.io-parser/releases) - [Changelog](https://github.com/socketio/socket.io-parser/blob/3.3.2/CHANGELOG.md) - [Commits](socketio/socket.io-parser@3.3.0...3.3.2) --- updated-dependencies: - dependency-name: socket.io-parser dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Bump path-parse from 1.0.6 to 1.0.7 Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Bump tar from 4.4.10 to 4.4.19 Bumps [tar](https://github.com/npm/node-tar) from 4.4.10 to 4.4.19. - [Release notes](https://github.com/npm/node-tar/releases) - [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v4.4.10...v4.4.19) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Bump lodash from 4.17.11 to 4.17.21 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.11...4.17.21) --- updated-dependencies: - dependency-name: lodash dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Bump y18n from 4.0.0 to 4.0.3 Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.3. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/y18n-v4.0.3/CHANGELOG.md) - [Commits](yargs/y18n@v4.0.0...y18n-v4.0.3) --- updated-dependencies: - dependency-name: y18n dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Bump socket.io from 2.2.0 to 2.4.1 Bumps [socket.io](https://github.com/socketio/socket.io) from 2.2.0 to 2.4.1. - [Release notes](https://github.com/socketio/socket.io/releases) - [Changelog](https://github.com/socketio/socket.io/blob/2.4.1/CHANGELOG.md) - [Commits](socketio/socket.io@2.2.0...2.4.1) --- updated-dependencies: - dependency-name: socket.io dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * add contact namespace to contact model * add external identifiers edit and view interface * temporarily point to development mdTranslator service * don't need this test header any more :P * change contact externalIdentifier namespace input to a picklist * validations for contact external identifiers * try it without the dash * update mdjson-schemas * change externalIdentifiers to singular per mdJson-schema standard * use namespace codelist for contact.externalIdentifier * fix external identifiers on contact#show * update mdCodes for ROR and ORCID identifiers Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Devon Anderson <devon_anderson@fws.gov> * pointing the editor at the production sciencebase translator instance (#493) * actually import / export dictionaryId (#496) fixes adiwg/mdTranslator#238 * add a default value for externalIdentifiers, since imported contacts won't have it set Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Josh Bradley <jbradley@arcticlcc.org> Co-authored-by: Devon Anderson <dvonanderson@gmail.com> Co-authored-by: Josh Bradley <joshua_bradley@fws.gov> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Devon Anderson <devon_anderson@fws.gov> Co-authored-by: dvonanderson <devon.anderson@hashicorp.com> Co-authored-by: Tim Zwolak <timothypage@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug:
While upgrading from Ember 3.7 to 3.8 I encountered an issue where any
modal-dialogcomponent I used withtetherTargetattribute would fire an issue deep in the internals of Ember/Glimmer runtime that saidCannot call nextSibling of null.Work around:
It appears that the
modal-dialogcomponent hastagName: ''set by default. By settingtagName="div"on instantiation of themodal-dialogcomponent I was able to avoid this error.Cause:
I'm not 100% clear on the cause but it seems like the
modal-dialogis being used as a node by the runtime but having no DOM element confuses it. This may be a runtime error, and not amodal-dialogbug, but starting issue here as this addon probably needs to be upgraded and will likely find the same issue.The text was updated successfully, but these errors were encountered: