Updates for Ember 1.13. #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change scenario names to match the default ones added by ember-cli (and used by ember-modal-dialog/ember-tether) * Make 1.13 the default version.
* Only use `Ember.View.views` as a fallback if `-view-registry:main` is not available. * Remove assertion confirming that different elements are created upon `.rerender()` (a rerender in Ember 1.13 maintains the same element).
rwjblue
force-pushed
the
update-test-suite-for-1-13
branch
from
465f0a6 to
319d844
Compare
|
I'm not really sure why Ember 1.11.3 is tanking in Travis (seems like phantomjs just crashes). I'll try to play with it some more tonight/tomorrow. |
|
before_install:
- mkdir travis-phantomjs
- wget https://s3.amazonaws.com/travis-phantomjs/phantomjs-2.0.0-ubuntu-12.04.tar.bz2 -O $PWD/travis-phantomjs/phantomjs-2.0.0-ubuntu-12.04.tar.bz2
- tar -xvf $PWD/travis-phantomjs/phantomjs-2.0.0-ubuntu-12.04.tar.bz2 -C $PWD/travis-phantomjs
- export PATH=$PWD/travis-phantomjs:$PATH
- "npm config set spin false"
- "npm install -g npm@^2" |
| }, | ||
| resolutions: { | ||
| "ember": "beta" | ||
| 'ember': '1.11.3' |
There was a problem hiding this comment.
What are your thoughts on using tilde dependencies for testing previous release versions?
|
@rwjblue I totally didn't see this and redid it on master, I didn't however do the ember try stuff |
|
#18 covered the ember-cli 1.13.1 upgrade and took care of the ember try stuff. I rebased and merged via #30. I stuck with @krisselden's approach to avoid use of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember.View.viewsas a fallback if-view-registry:mainis not available..rerender()(a rerender in Ember 1.13 maintains the same element).(and used by ember-modal-dialog/ember-tether)