Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Glimmer2] Use the document service for glimmer #73

Merged
merged 1 commit into from
Oct 18, 2016

Conversation

chadhietala
Copy link
Contributor

No description provided.

@lukemelia
Copy link
Contributor

@chadhietala thanks for working on this. It looks like there are a lot of failing tests from this PR.

@chadhietala
Copy link
Contributor Author

@lukemelia Yea sorry forgot to import getOwner. Should be good now. Was wondering if you could do a release as well sense this breaks in FastBoot.

@lukemelia lukemelia merged commit 6868cee into yapplabs:master Oct 18, 2016
@chadhietala chadhietala deleted the fix-dom-lookup branch October 18, 2016 19:47
@lukemelia
Copy link
Contributor

Thanks @chadhietala. Released as 0.5.0. Would love a confirmation that it works in Fastboot for you.

@miguelcobain
Copy link

miguelcobain commented Oct 19, 2016

Does this line https://github.com/yapplabs/ember-wormhole/blob/master/addon/utils/dom.js#L51
make sense with this one https://github.com/yapplabs/ember-wormhole/blob/master/addon/components/ember-wormhole.js#L41 ?

I'm getting errors because we're basically looking document in document.
It happens on latest beta 2.10 and ember-wormhole 0.5.0.

@krisselden
Copy link
Contributor

This is not glimmer specific this worked before glimmer

@miguelcobain
Copy link

miguelcobain commented Oct 19, 2016

@krisselden I think I didn't understand what you mean, sorry.

The point is that this PR makes getDOM return document on glimmer 2.
Then the component looks up document again on that returned value.

Isn't this a bug?

@miguelcobain
Copy link

Update: I've downgraded to 0.4.1 and tests now pass in all ember-try scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants