Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update has transformed #34

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Update has transformed #34

merged 3 commits into from
Jun 23, 2023

Conversation

kameyer226
Copy link
Contributor

added native_limits as a config option for has-transformed-position trait

@ddkohler
Copy link
Contributor

@kameyer226 I got a message to review this PR, but it looks like it's not done yet? I'm expecting this PR will resolve yaq-project/yaq-python#56 . Let me know if there is something you want checked at this point.

@ddkohler
Copy link
Contributor

@kameyer226 I got a message to review this PR, but it looks like it's not done yet? I'm expecting this PR will resolve yaq-project/yaq-python#56 . Let me know if there is something you want checked at this point.

My bad--I didn't check the repo and thought that this was a PR for yaq-python...

Copy link
Contributor

@ddkohler ddkohler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a better docstring, looks good!

Co-authored-by: Daniel Kohler <11864045+ddkohler@users.noreply.github.com>
@ddkohler ddkohler merged commit de8ae54 into main Jun 23, 2023
@ddkohler ddkohler deleted the update_has_transformed branch June 23, 2023 20:49
@untzag
Copy link
Member

untzag commented Jun 25, 2023

@kameyer226 @ddkohler please update the YEP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants