(feat) initial version #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
ictbeheer
force-pushed
the
feat/initial-version
branch
from
6d2e6bd to
0c25e1b
Compare
phpstan.neon.dist
Outdated
| paths: | ||
| - src | ||
| tmpDir: build/phpstan | ||
| ignoreErrors: | ||
| - | ||
| message: '#Call to an undefined static method Yard\\SkeletonPackage\\Facades\\Example::getQuote\(\)#' | ||
| message: '#Call to an undefined static method Yard\\UserRoles\\Facades\\UserRoles::getQuote\(\)#' |
There was a problem hiding this comment.
Je hebt denk ik niet de laatste versie van de skeleton package? yardinternet/skeleton-package@c72e49d
ictbeheer
force-pushed
the
feat/initial-version
branch
from
0c25e1b to
16a9840
Compare
ictbeheer
force-pushed
the
feat/initial-version
branch
from
16a9840 to
7304427
Compare
|
Coverage report for commit: c8c5fd8 Summary - Lines: - | Methods: -
🤖 comment via lucassabreu/comment-coverage-clover |
||||||||||||||||||||||||||||||||
SimonvanWijhe
approved these changes
Aug 6, 2024
src/UserRoles.php
Outdated
|
|
||
|
|
||
| //Remove current custom roles | ||
| $current_roles = \wp_roles()->roles; |
src/UserRoles.php
Outdated
| Assert::stringNotEmpty($prefix); | ||
|
|
||
|
|
||
| //Remove current custom roles |
There was a problem hiding this comment.
Een aparte method voor maken?
|
|
||
| Assert::isArray($roles); | ||
| Assert::stringNotEmpty($prefix); | ||
|
|
src/UserRoles.php
Outdated
|
|
||
| private function setRolesForSite(): void | ||
| { | ||
|
|
src/UserRoles.php
Outdated
|
|
||
| //Remove current custom roles | ||
| $current_roles = \wp_roles()->roles; | ||
| $current_roles = array_filter( |
src/UserRoles.php
Outdated
| remove_role($role); | ||
| } | ||
|
|
||
| // Add custom roles |
There was a problem hiding this comment.
Aparte method voor maken. addCustomRoles() dan kan de comment weg
src/UserRoles.php
Outdated
| $capabilities = []; | ||
|
|
||
| $capGroups = config('user-roles.cap_groups'); | ||
| Assert::isArray($capGroups); |
There was a problem hiding this comment.
$capGroups kan ook leeg zijn. Dan kan deze stap worden overgeslagen (nu krijg je een exception)
src/UserRoles.php
Outdated
|
|
||
| $capGroups = config('user-roles.cap_groups'); | ||
| Assert::isArray($capGroups); | ||
| foreach ($properties['cap_groups'] as $group) { |
There was a problem hiding this comment.
Ook $properties['cap_groups'] kan leeg zijn.
src/UserRoles.php
Outdated
| } | ||
| } | ||
|
|
||
| foreach ($properties['post_type_caps'] as $postType) { |
There was a problem hiding this comment.
En $properties['post_type_caps'] kan ook leeg zijn.
src/UserRoles.php
Outdated
| foreach ($properties['post_type_caps'] as $postType) { | ||
| $postTypeCaps = get_post_type_object($postType)?->cap; | ||
| Assert::object($postTypeCaps); | ||
| foreach(array_values((array)$postTypeCaps) as $cap) { |
There was a problem hiding this comment.
of
foreach($postTypeCaps as $key => $cap) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.