Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop cjs #129

Closed
wants to merge 1 commit into from
Closed

drop cjs #129

wants to merge 1 commit into from

Conversation

PierreDemailly
Copy link

Dropped CJS & Deno support.
Updated deps.
Fixes NodeSecure/cli#93.
Fixes wrapped alignment.
Fixes :align: right no longer overflow container width.

This PR introduce breaking changes.

  • divs are now block & full-width so spans can no longer be aligned right/left a div.
    ui.div('my div', 'my div')
    is now same as
    ui.div('my div'); ui.div('my div')
  • align: right with weird padding/width can be laggy.
  • some tests have been adjusted to pass, it's about leading/trailing whitespaces & align: right changes. I've made multiple tests (function tests on my side) and it seem ok for all basic usage, and more.

@fraxken fraxken deleted the drop-cjs branch December 22, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixing CLIUI ESM color issue.
1 participant