Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add recursive support to fslib opendir/readdir #5423

Open
2 tasks done
RDIL opened this issue May 3, 2023 · 0 comments
Open
2 tasks done

[Feature] Add recursive support to fslib opendir/readdir #5423

RDIL opened this issue May 3, 2023 · 0 comments
Assignees
@RDIL
Labels
enhancement New feature or request

Comments

@RDIL
Copy link
Member

RDIL commented May 3, 2023

  • I'd be willing to implement this feature (contributing guide)
  • This feature is important to have in this repository; a contrib plugin wouldn't do

Describe the user story
See nodejs/node#41439
@RDIL RDIL added the enhancement New feature or request label May 3, 2023
@RDIL RDIL self-assigned this May 3, 2023
@arcanis arcanis mentioned this issue Jun 22, 2023
Merged
3 tasks
arcanis added a commit that referenced this issue Jun 24, 2023
@arcanis
Implements the readdir recursive flag (#5514)
69ecb99 
**What's the problem this PR addresses?**
The `ZipFS` implementation doesn't support the `recursive` flag.

Fixes part of #5423

**How did you fix it?**
I implemented the `recursive` flag and updated the types to account for
it. However I didn't make `ZipOpenFS` automatically traverse through zip
archives ... My line of thinking was:

> - on one hand, tools implementing their own readdir-based recursive
traversal don't currently dig into zip archives
> - on the other hand, it can be argued that the other recursive Node.js
native operations also apply to the zip archives' content (`cp` / `rm`)
>
> But I tend to think the first point is more important ... I feel like
the recursive flag should just be an optimization, so it should have the
same behaviour as a manual traversal ...

**Checklist**
<!--- Don't worry if you miss something, chores are automatically
tested. -->
<!--- This checklist exists to help you remember doing the chores when
you submit a PR. -->
<!--- Put an `x` in all the boxes that apply. -->
- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).

<!-- See
https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
for more details. -->
<!-- Check with `yarn version check` and fix with `yarn version check
-i` -->
- [x] I have set the packages that need to be released for my changes to
be effective.

<!-- The "Testing chores" workflow validates that your PR follows our
guidelines. -->
<!-- If it doesn't pass, click on it to see details as to what your PR
might be missing. -->
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RDIL RDIL

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RDIL