Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Automatically unplug dependencies with binary executables #663

Closed
1 of 2 tasks
merceyz opened this issue Jan 2, 2020 · 0 comments · Fixed by #853
Closed
1 of 2 tasks

[Feature] Automatically unplug dependencies with binary executables #663

merceyz opened this issue Jan 2, 2020 · 0 comments · Fixed by #853
Labels
enhancement New feature or request

Comments

@merceyz
Copy link
Member

merceyz commented Jan 2, 2020

  • I'd be willing to implement this feature
  • This feature can already be implemented through a plugin

Describe the user story

When a user is trying to build an electron project using electron-builder the build fails because Windows can't execute an exe file within a zip archive

Describe the solution you'd like

That Yarn would detect that a dependency has executeable files and automatically unplug said dependency

Describe the drawbacks of your solution

Yarn would have to do more work at install time

Describe alternatives you've considered

  • Opening a PR upstream to add a empty postinstall script just to have yarn unplug it automatically, this would only solve the problem for this one dependency.
  • Running yarn unplug on the offending package(s), creates another hurdle for PnP adoptation

Additional context
Where electron-builder spawns the package
https://github.com/electron-userland/electron-builder/blob/e1a7ec9f3f7dde69b99dc8c809aac688803ee9a9/packages/builder-util/src/util.ts#L337-L369
The package that needs to be unplugged:
https://github.com/Loller79/app-builder-bin

@merceyz merceyz added the enhancement New feature or request label Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant