ci: run tests on node 14 #1239
Merged
ci: run tests on node 14 #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Things seem a bit broken on Node 14. (e.g. #1236)
I've just done a quick check locally (only including the files mentioned below) and:- 12/18 tests fail forscript.test.js- 8/12 tests fail forrequire.test.js- 3/62 tests fail forpnp.test.js- 3/8 tests fail fornode-modules.test.tsEdit: Apparently that only happens locally to me, that's why I made the PR, to see if it reproduces on CI. It seems there's only one error with Node 14, and it's not one of the original ones I got. Sorry for the heart attack. 😄
How did you fix it?
For now, I made the tests also run on Node 14 on CI, so we can see everything that's failing more easily.