fix(core): ignore node_modules and .git folders for workspaces #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
reviewed
Jun 19, 2020
| @@ -69,6 +69,7 @@ export class Workspace { | |||
| expandDirectories: false, | |||
| onlyDirectories: true, | |||
| onlyFiles: false, | |||
| ignore: [`node_modules`, `.git`], | |||
There was a problem hiding this comment.
Shouldn't the .yarn folder be ignored as well, btw? Otherwise it'll detect the unplugged directory.
There was a problem hiding this comment.
Yeah, it should. I forgot about that one.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
When specifying a globstar pattern for workspaces, the
node_modulesfolders aren't ignored which causesduplicate workspace nameerrors.Fixes #1297
Fixes #1191
How did you fix it?
Ignore
node_modulesand.gitfolders when searching for workspacesChecklist