chore(compat): tailwindcss related compat extensions #2974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 2, 2021 15:36
Two of the official tailwindcss plugins implicitly used tailwindcss as a peer dependency but didn't list it; they have since been fixed, and this adds compatibility for earlier versions. See tailwindlabs/tailwindcss-aspect-ratio#14, tailwindlabs/tailwindcss-line-clamp#6
@fullhuman/postcss-purgecss removed postcss as a peer dependency for version `3.1.3`, which was incorrect and it was added back in the next release, `4.0.0`. Unfortunately, tailwindcss is stuck on this version of postcss-purgecss for compatibility reasons, so this commit adds compatibility for @fullhuman/postcss-purgecss@3.1.3. See FullHuman/purgecss@ff2eff5, FullHuman/purgecss@24116f3,
merceyz
reviewed
Jun 2, 2021
`@fullhuman/postcss-purgecss@3.1.3` had a prerelease tag `alpha.0` that needed to be added. Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
tailwindcss currently does not work with yarn PnP due to issues with a dependency and a couple plugins. This PR adds the necessary compat data for tailwindcss and all the official plugins to work out of the box.
How did you fix it?
For the official tailwindcss extensions, I submitted PRs to add the correct peer dependencies (tailwindlabs/tailwindcss-aspect-ratio#14, tailwindlabs/tailwindcss-line-clamp#6) that have since been accepted, and added compat data for older versions. There is also a specific version of postcss-purgecss that was missing a peer dependency for postcss, and tailwindcss is pinned to that version for compatibility reasons, so I added compat data for the specific version in question.
Checklist