Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: e2e - enable PnP ESM loader in all tests #4088

Merged
merged 1 commit into from
Feb 10, 2022
Merged

ci: e2e - enable PnP ESM loader in all tests #4088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/actions/prepare/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ runs:
steps:
- uses: actions/setup-node@master
with:
node-version: 14.x
node-version: 16.x
check-latest: true

#region Build the standard bundle
- uses: actions/cache@v2
Expand Down
8 changes: 0 additions & 8 deletions .github/workflows/e2e-docusaurus-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,20 +24,12 @@ jobs:
- name: 'Running the integration test'
run: |
source scripts/e2e-setup-ci.sh

# TODO: Remove once https://github.com/yarnpkg/berry/blob/bd146ccddf95aae9c99c0c48d86b1d8997f1dccf/scripts/e2e-setup-ci.sh#L31-L38 is fixed
YARN_PNP_ENABLE_ESM_LOADER=true

yarn dlx create-docusaurus@latest my-website classic && cd my-website
yarn build

- name: 'Running the TypeScript integration test'
run: |
source scripts/e2e-setup-ci.sh

# TODO: Remove once https://github.com/yarnpkg/berry/blob/bd146ccddf95aae9c99c0c48d86b1d8997f1dccf/scripts/e2e-setup-ci.sh#L31-L38 is fixed
YARN_PNP_ENABLE_ESM_LOADER=true

yarn dlx create-docusaurus@latest my-website-ts classic --typescript && cd my-website-ts
yarn build
if: |
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/e2e-pnp-angular-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ jobs:
run: |
source scripts/e2e-setup-ci.sh

# TODO: Remove once https://github.com/yarnpkg/berry/blob/bd146ccddf95aae9c99c0c48d86b1d8997f1dccf/scripts/e2e-setup-ci.sh#L31-L38 is fixed
YARN_PNP_ENABLE_ESM_LOADER=true

# TODO: Angular should be fixed to detect the correct package manager to install with
# but for now we need to specify it
yarn dlx -p @angular/cli@next ng new berry-angular --interactive=false --package-manager yarn
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/e2e-svelte-kit-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,6 @@ jobs:
- name: 'Running the integration test'
run: |
source scripts/e2e-setup-ci.sh

# TODO: Remove once https://github.com/yarnpkg/berry/blob/bd146ccddf95aae9c99c0c48d86b1d8997f1dccf/scripts/e2e-setup-ci.sh#L31-L38 is fixed
YARN_PNP_ENABLE_ESM_LOADER=true

yes | yarn create svelte@next my-app && cd my-app
yarn
yarn build
9 changes: 0 additions & 9 deletions scripts/e2e-setup-ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,6 @@ export YARN_ENABLE_IMMUTABLE_INSTALLS=0
# We want to make sure the projects work in a monorepo
export YARN_PNP_FALLBACK_MODE=none

# TODO: Remove when either of these issues are fixed
# - https://github.com/nodejs/node/issues/39140
# - https://github.com/nodejs/node/issues/37782
# - https://github.com/facebook/jest/issues/12060
# Due to a bug in `jest-worker` and/or Node.js adding a loader
# causes our e2e tests to time out so require the tests that needs it
# to explicitly enable it
export YARN_PNP_ENABLE_ESM_LOADER=false

# Otherwise git commit doesn't work, and some tools require it
git config --global user.email "you@example.com"
git config --global user.name "John Doe"
Expand Down