fix(fslib): fix FileHandle
implementations
#4410
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
This PR fixes the following
patchFs
issues:fs.write
now returns an objecthandle.read
now returns an objecthandle.write
now returns an objecthandle.truncate
and other methods that expectpath
instead offd
Resolves #4372.
How did you fix it?
fs.write
implementation, similar to fix: Match promisified fs.read call return with original implementation #2128handle.read
andhandle.write
implementations that use promisifiedfs.read
andfs.write
FileHandle
for storing the file handle path so it can be passed to methods liketruncatePromise
, which expectpath
instead offd
FILEHANDLE_IMPLEMENTATIONS
to specify whether a method expectsfd
(e.g.readFilePromise
) orpath
(e.g.truncatePromise
)Checklist