fix(pnp): handle private import mappings #4862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
force-pushed
the
merceyz/fix/pnp-imports
branch
from
bbc640e
to
aa96387
Compare
|
For the Node core code, should there be a plan in place for when and how to update it? |
merceyz
force-pushed
the
merceyz/fix/pnp-imports
branch
2 times, most recently
from
5bb2dad
to
600d4e9
Compare
Usually we update whenever someone tells us something doesn't seem to work compared to Node - it's not ideal, and hopefully it'll work better if Node provides a blessed resolution library. |
arcanis
reviewed
Sep 19, 2022
merceyz
force-pushed
the
merceyz/fix/pnp-imports
branch
from
600d4e9
to
240af2c
Compare
merceyz
force-pushed
the
merceyz/fix/pnp-imports
branch
from
ac286f1
to
b634e55
Compare
arcanis
approved these changes
Sep 28, 2022
merceyz
added a commit
that referenced
this pull request
Sep 28, 2022
* fix(pnp): handle private import mappings * refactor: don't use `assert` * fix: forward extensions * refactor: `resolvePrivateRequest` * test: fix test for mapping to a dependency * fix: legacy fallback when mapping Co-authored-by: Maël Nison <nison.mael@gmail.com>
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Node.js supports an
importsfield inpackage.jsonthat the PnP API doesn't support yet.https://nodejs.org/dist/latest-v18.x/docs/api/packages.html#imports
Fixes #3843
Ref nodejs/node#40579
How did you fix it?
Extracted the required code from Node.js and adapted it to work with PnP.
Checklist