-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace @babel/register
with esbuild-wasm
#5180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
force-pushed
the
merceyz/chore/esbuild-dev
branch
from
January 22, 2023 14:31
c283a6a
to
40cf4c7
Compare
merceyz
force-pushed
the
merceyz/chore/esbuild-dev
branch
2 times, most recently
from
February 4, 2023 14:38
c69dc83
to
782532d
Compare
merceyz
changed the title
chore: use esbuild for running sources
chore: replace Feb 4, 2023
@babel/register
with esbuild
merceyz
changed the title
chore: replace
chore: replace Feb 4, 2023
@babel/register
with esbuild
@babel/register
with esbuild-wasm
merceyz
force-pushed
the
merceyz/chore/esbuild-dev
branch
from
February 4, 2023 14:52
b9137d2
to
947672a
Compare
A fresh cache is 2212kB for 263 files so unlikely to become a problem.
Runtime performance is roughly the same but the cache size shrinks: ```diff $ du -s node_modules/.cache/yarn/ - 2212 node_modules/.cache/yarn/ + 1464 node_modules/.cache/yarn/ ```
merceyz
force-pushed
the
merceyz/chore/esbuild-dev
branch
from
February 15, 2023 11:58
f1c7428
to
90af620
Compare
Significantly faster indeed, nice! |
arcanis
previously approved these changes
Feb 15, 2023
arcanis
approved these changes
Feb 15, 2023
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
**What's the problem this PR addresses?** <!-- Describe the rationale of your PR. --> <!-- Link all issues that it closes. (Closes/Resolves #xxxx.) --> #5180 replaced `@babel/register` with `esbuild` but the docs were not updated **How did you fix it?** <!-- A detailed description of your implementation. --> Update docs accordingly **Checklist** <!--- Don't worry if you miss something, chores are automatically tested. --> <!--- This checklist exists to help you remember doing the chores when you submit a PR. --> <!--- Put an `x` in all the boxes that apply. --> - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). <!-- See https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released for more details. --> <!-- Check with `yarn version check` and fix with `yarn version check -i` --> - [x] I have set the packages that need to be released for my changes to be effective. <!-- The "Testing chores" workflow validates that your PR follows our guidelines. --> <!-- If it doesn't pass, click on it to see details as to what your PR might be missing. --> - [x] I will check that all automated PR checks pass before the PR gets reviewed.
merceyz
added a commit
that referenced
this pull request
Dec 25, 2023
* chore: use esbuild for running sources * deps: update esbuild * chore: remove babel setup * refactor: only use builtin sourcemap support * refactor: remove weekly cache pruning A fresh cache is 2212kB for 263 files so unlikely to become a problem. * fix: disable dynamic imports * chore: workaround issue on windows * fix: support node nightly * chore: link to issues * perf: use brotli Runtime performance is roughly the same but the cache size shrinks: ```diff $ du -s node_modules/.cache/yarn/ - 2212 node_modules/.cache/yarn/ + 1464 node_modules/.cache/yarn/ ``` * Minor stylistic tweaks --------- Co-authored-by: Maël Nison <nison.mael@gmail.com> (cherry picked from commit 8e2028e)
merceyz
added a commit
that referenced
this pull request
Dec 25, 2023
* chore: use esbuild for running sources * deps: update esbuild * chore: remove babel setup * refactor: only use builtin sourcemap support * refactor: remove weekly cache pruning A fresh cache is 2212kB for 263 files so unlikely to become a problem. * fix: disable dynamic imports * chore: workaround issue on windows * fix: support node nightly * chore: link to issues * perf: use brotli Runtime performance is roughly the same but the cache size shrinks: ```diff $ du -s node_modules/.cache/yarn/ - 2212 node_modules/.cache/yarn/ + 1464 node_modules/.cache/yarn/ ``` * Minor stylistic tweaks --------- Co-authored-by: Maël Nison <nison.mael@gmail.com> (cherry picked from commit 8e2028e)
merceyz
added a commit
that referenced
this pull request
Dec 25, 2023
* chore: use esbuild for running sources * deps: update esbuild * chore: remove babel setup * refactor: only use builtin sourcemap support * refactor: remove weekly cache pruning A fresh cache is 2212kB for 263 files so unlikely to become a problem. * fix: disable dynamic imports * chore: workaround issue on windows * fix: support node nightly * chore: link to issues * perf: use brotli Runtime performance is roughly the same but the cache size shrinks: ```diff $ du -s node_modules/.cache/yarn/ - 2212 node_modules/.cache/yarn/ + 1464 node_modules/.cache/yarn/ ``` * Minor stylistic tweaks --------- Co-authored-by: Maël Nison <nison.mael@gmail.com> (cherry picked from commit 8e2028e)
Woodpile37
pushed a commit
to Woodpile37/berry
that referenced
this pull request
Jan 10, 2024
* chore: use esbuild for running sources * deps: update esbuild * chore: remove babel setup * refactor: only use builtin sourcemap support * refactor: remove weekly cache pruning A fresh cache is 2212kB for 263 files so unlikely to become a problem. * fix: disable dynamic imports * chore: workaround issue on windows * fix: support node nightly * chore: link to issues * perf: use brotli Runtime performance is roughly the same but the cache size shrinks: ```diff $ du -s node_modules/.cache/yarn/ - 2212 node_modules/.cache/yarn/ + 1464 node_modules/.cache/yarn/ ``` * Minor stylistic tweaks --------- Co-authored-by: Maël Nison <nison.mael@gmail.com> (cherry picked from commit 8e2028e)
arcanis
pushed a commit
that referenced
this pull request
Jul 1, 2024
**What's the problem this PR addresses?** We use esbuild to build and run Yarn from sources but not for our test files. Follow-up to #5180 **How did you fix it?** Use esbuild to transpile files in our testing setup. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Running Yarn from sources is a bit slow.
Ref #2228
How did you fix it?
Replaced
@babel/register
with a custom setup usingesbuild-wasm
Results
Checklist