Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
toPortablePath
/fromPortablePath
were exposed from bothNodeFS
andpath.ts
.FakeFS
without implementing each and every method.How did you fix it?
toPortablePath
andfromPortablePath
are moved intonpath
. Callsites are updated.NoFS
implementation will throw at runtime for each unimplemented method.npath
andppath
now expose an utility calledcontains
which returnsnull
if the second parameter isn't contained in the first one, or the subpath otherwise.