Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More FSLib improvements #535

Merged
merged 13 commits into from
Oct 18, 2019
Merged

More FSLib improvements #535

merged 13 commits into from
Oct 18, 2019

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Oct 18, 2019

This diff does multiple things (cf individual commits for details):

  • Slightly refactors the ZipFS to abstract errors into their own file
  • Adds support for the mkdir options (fixes [Bug] Interception of fs doesn't pass options to readdirSync #509)
  • Registers the mkdir patch to the fs module
  • Makes ZipOpenFS and ZipFS support read-only archives
  • Removes the read-only code from NodeModulesFS (to instead use the builtin one)

@arcanis arcanis force-pushed the mael/fslib-improvements-2 branch from 46509b6 to 8f4d5b3 Compare October 18, 2019 10:54
@arcanis arcanis merged commit 3686817 into master Oct 18, 2019
@arcanis arcanis deleted the mael/fslib-improvements-2 branch October 18, 2019 12:23
This was referenced Jun 21, 2023
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Interception of fs doesn't pass options to readdirSync
1 participant
@arcanis