New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marks the "path" property as always-there when withFileTypes is set #6160

Open

arcanis wants to merge 1 commit into master from mael/readdir-path

+115 −79

Member

arcanis commented Mar 9, 2024

What's the problem this PR addresses?

The path field has always been set when withFileTypes: true is present, even without the recursive: true flag, ever since 18.17.

How did you fix it?

Fixes the types to reflect that path is always set.

A follow-up PR will have to find a solution to rename path into parentPath in a way that's backward compatible :/

nodejs/node#51050

Checklist

I have read the Contributing Guide.

I have set the packages that need to be released for my changes to be effective.

I will check that all automated PR checks pass before the PR gets reviewed.


          Marks the "path" property as always-there when withFileTypes is set

9eab04b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet