feat(builder): transform node: imports as needed
#6356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jkowalleck
changed the title
node: imports as needed
jkowalleck
changed the title
node: imports as neededyarnpkg/builder for plugins transform node: imports as needed
arcanis
reviewed
Jun 28, 2024
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
|
rebased on master. |
|
any hope to get this merged soon? |
jkowalleck
commented
Aug 25, 2024
merceyz
changed the title
yarnpkg/builder for plugins transform node: imports as needednode: imports as needed
merceyz
approved these changes
Aug 25, 2024
|
Thanks for the PR, sorry it took so long to get it landed. |
I am happy seeing this merged, and looking forward to having this available with the next release badge. |
This was referenced Aug 25, 2024
|
Yay 🎉 |
I've created a new release so it should be available now. |
yes, the changes are included in v4.2.0 🚀 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Yarn plugins used to be forbidden to import/require built-in modules prefixed with
node:.see #6135
see #5417
Fixes #5637
The yarn plugin builder should be aware of this fact and produce bundled code, that does not contain any
node:prefixed import/require.This is especially important when building plugins with 3rd party dependencies, where the plugin author cannot "fix" the imports to yarn's needs.
How did you fix it?
I enabled the plugin-compiler to generate the plugin-code as needed:
I utilized the capability of
esbuildto strip thesenode:prefixes from import/require instructions.Therefore, I added config options to the plugin build process to instruct
esbuildto do so.This is a fix of the plugin builder, which enables plugin authors to compile their work in a backwards-compatible way, so that the build result is runnable in old/unpatched versions of yarn. Unpatched regarding #5997
Related
The #5997 tries to address the issue from the plugin-runtime side.
This would enable "broken" plugins to be runnable in all future/patched versions of yarn-core.
Additionally
This very PR aims to enable plugin authors to create plugins that are runnable with unpatched versions of yarn-core.
It is considered a friction-free backwards-compatible solution on all ends. Yet it does not replace #5997.
Checklist