Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): fix Next.js E2Es failing since next@canary requires React 19 #6446

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −9
Open

fix(ci): fix Next.js E2Es failing since next@canary requires React 19 #6446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions .github/workflows/e2e-next-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,10 @@ jobs:
yarn init

# Required
yarn add next@canary react react-dom

# Test itself
yarn add raw-loader
yarn add next@canary react@rc react-dom@rc

mkdir pages
echo 'import text from "raw-loader!./text.txt"; export default () => <div>{text}</div>;' | tee pages/index.js
echo 'hello world!' | tee pages/text.txt
echo 'export default () => <div>Hello world!</div>;' | tee pages/index.js

yarn next build

Expand All @@ -44,14 +40,13 @@ jobs:
yarn init

# Required
yarn add typescript next@canary react react-dom @types/react @types/react-dom @types/node
yarn add typescript next@canary react@rc react-dom@rc @types/react @types/react-dom @types/node

# Test itself
yarn add raw-loader

mkdir pages
echo 'const text = require("raw-loader!./text.txt").default; export default () => <div>{text}</div>;' | tee pages/home.tsx
echo 'hello world!' | tee pages/text.txt
echo 'export default () => <div>Hello world!</div>;' | tee pages/index.tsx

yarn next build
if: |
Expand Down
Loading