Skip to content

Conversation

smoores-dev
Copy link
Contributor

What's the problem this PR addresses?

When #6898 added support for OIDC publishing, it copied the getOidcToken function from npm's implementation. However, ciInfo was directly replaced with process.env, which coincidentally worked fine for GitHub Actions (both the ciInfo constant and the environment variable are named GITHUB_ACTIONS), but not for GitLab (the ciInfo constant is GITLAB, but the actual env var is GITLAB_CI.

How did you fix it?

Replaced process.env.GITLAB with process.env.GITLAB_CI

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants