fix: use correct env var to detect gitlab CI for OIDC #6938
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
When #6898 added support for OIDC publishing, it copied the getOidcToken function from npm's implementation. However,
ciInfo
was directly replaced withprocess.env
, which coincidentally worked fine for GitHub Actions (both theciInfo
constant and the environment variable are namedGITHUB_ACTIONS
), but not for GitLab (theciInfo
constant isGITLAB
, but the actual env var isGITLAB_CI
.How did you fix it?
Replaced
process.env.GITLAB
withprocess.env.GITLAB_CI
Checklist