PnP: Allow FileHandle#read into TypedArrays and DataViews
#6950
+301
−109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Fixes #6890
Fixes #6145
Node's implementation of
FileHandle#readallows reading intoTypedArrays andDataViews (collectively known asArrayBufferViews, and checks for them usingArrayBuffer.isView().On the other hand, our implementation checks using
Buffer.isBuffer()and thus only allowsBuffer. If anArrayBufferViewis given, it treats them as an options bag and pass its.buffer(which is anArrayBuffer) as the sink to the backing fs. If the backing fs is Node's nativefsthen it would throw.How did you fix it?
Allow
ArrayBufferViews by checking withArrayBuffer.isView()as in Node's implementation.Because the underlying
FakeFSinterface only allowsBuffer(and changing that would be a breaking change), aBufferbacked by theArrayBufferViewis used. (Q: Should we make that change next major?)Also un-vendored the TypeScript types if the exact same type is available from
@types/nodealong the way. AFAICT those were vendored because those types wasn't available at first? \cc @merceyzThis fix should be orthogonal to #6919
Checklist