.bin folder missing when using --modules-folder
#4297
Comments
|
This looks like a duplicate of #3724. Please confirm :) |
|
I have the same issue, looks like duplicate of #3724 |
|
Any update on this, I have been stuck on |
|
Any update on this? We're also blocked by this. |
voondo
added a commit
to voondo/yarn
that referenced
this issue
Apr 26, 2018
…e `--modules-folder` flag (yarnpkg#3724, yarnpkg#4297) **Summary** This PR fixes yarnpkg#3724 and yarnpkg#4297 where `install` was not installing binary symlinks to the correct location when the `--modules-folder` flag was provided. **Test plan** Manual CLI tests: Before: ``` > yarn --modules-folder /var/foo > (ls /var/foo/.bin 2>1 > /dev/null && echo "found") || echo "not found" not found ``` After: ``` > yarn --modules-folder /var/foo > (ls /var/foo/.bin 2>1 > /dev/null && echo "found") || echo "not found" found ```
voondo
added a commit
to voondo/yarn
that referenced
this issue
Apr 27, 2018
…e `--modules-folder` flag (yarnpkg#3724, yarnpkg#4297) **Summary** This PR fixes yarnpkg#3724 and yarnpkg#4297 where `install` was not installing binary symlinks to the correct location when the `--modules-folder` flag was provided. **Test plan** Manual CLI tests: Before: ``` > yarn --modules-folder /var/foo > (ls /var/foo/.bin 2>1 > /dev/null && echo "found") || echo "not found" not found ``` After: ``` > yarn --modules-folder /var/foo > (ls /var/foo/.bin 2>1 > /dev/null && echo "found") || echo "not found" found ```
voondo
added a commit
to voondo/yarn
that referenced
this issue
Apr 27, 2018
…e `--modules-folder` flag (yarnpkg#3724, yarnpkg#4297) **Summary** This PR tries to fixes yarnpkg#3724 and yarnpkg#4297 where `install` was not installing binary symlinks to the correct location when the `--modules-folder` flag was provided. WIP - CURRENTLY DOESN'T WORK, DON'T MERGE IT **Test plan** Manual CLI tests: Before: ``` > yarn --modules-folder /var/foo > (ls /var/foo/.bin 2>1 > /dev/null && echo "found") || echo "not found" not found ``` After: ``` > yarn --modules-folder /var/foo > (ls /var/foo/.bin 2>1 > /dev/null && echo "found") || echo "not found" found ``` Automatic test: __tests__/commands/install/bin-links.js -t "install should respect --modules-folder flag" **Remaining issues** * Problem with `yarn check --verify-tree`: ``` error "standard#eslint" not installed error "standard#eslint-config-standard" not installed error "standard#eslint-config-standard-jsx" not installed error "standard#eslint-plugin-promise" not installed error "standard#eslint-plugin-react" not installed error "standard#eslint-plugin-standard" not installed error "standard#standard-engine" not installed ``` * Automatic test fails (while manual CLI test works)
|
Closing in favor of #3724. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Do you want to request a feature or report a bug?
BUG
What is the current behavior?
.binis nowhere to be found.What is the expected behavior?
Behavior (as per yarn@0.24.4 and node@7.10.0) should be
.binfolder at/opt/app-node-modules/.binPlease mention your node.js, yarn and operating system version.
P.S. I see this behavior bumping our docker images to 8.4.0 from 7.10.0
The text was updated successfully, but these errors were encountered: