-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"registry" now requires a trailing slash to work correctly #4339
Comments
Just ran into this. Can confirm adding the |
yea can also confirm that this used to work fine without a trailing slash in my |
**Summary** Fixes #4339. Also fixes handling of upper-case registry names. **Test plan** Added unit tests for `NpmRegistry.prototype.getRequestUrl()`.
Sorry @kaylieEB, took this on since I'm hoping to release 1.0.2 with this fixed. |
**Summary** Fixes #4339. Also fixes handling of upper-case registry names. **Test plan** Added unit tests for `NpmRegistry.prototype.getRequestUrl()`.
no worries at all! I was just seeing this bug in prod too, thanks for fixing it quickly! |
**Summary** Fixes yarnpkg#4339. Also fixes handling of upper-case registry names. **Test plan** Added unit tests for `NpmRegistry.prototype.getRequestUrl()`.
Do you want to request a feature or report a bug?
bug
What is the current behavior?
When using the "registry" parameter in .npmrc and .yarnrc, you must now use a trailing slash. Otherwise it will fail with an error "Couldn't find package "" on the "npm" registry."
If the current behavior is a bug, please provide the steps to reproduce.
Note -- there is no /npm on the end
What is the expected behavior?
Should make a get request to "https://my-private-repo.com/artifactory/npm/react"
Please mention your node.js, yarn and operating system version.
yarn 1.0.1
node 8.4.0
OSX Sierra
Note -- this can be worked around by adding a trailing slash -- but this was working correctly in v0.27.5
The text was updated successfully, but these errors were encountered: