yarn publish --non-interactive still asks questions

[dmerejkowsky]

yarn 1.3.2
node 9.2.0

steps to reproduce

$ mkdir hello
$ yarn init
$ yarn publish --non-interactive

actual

yarn stops with:

yarn publish v1.3.2
[1/4] Bumping version...
info Current version: 1.0.0
question New version: 

expected

An error message stating that --non-interactive must be used with --new-version ?

notes

yarn --non-interactive also stops if no npm token is found.

[bestander]

Good find!
https://github.com/yarnpkg/yarn/blob/master/src/cli/commands/publish.js needs to respect this flaG!

Good first PR!

[iansu]

Is anyone working on this? If not then I'd like to do it.

[bestander]

@iansu, go ahead!

[iansu]

Will do. Just to confirm, the basic idea is to display an error if --non-interactive is specified without --new-version? And also just fail with an error if no NPM token is present instead of prompting for it?

[bestander]

Yeah, I think it should fail fast if it try to prompt in non interactive mode

…

On Mon, Dec 18, 2017 at 2:12 PM Ian Sutherland ***@***.***> wrote: Will do. Just to confirm, the basic idea is to display an error if --non-interactive is specified without --new-version? And also just fail with an error if no NPM token is present instead of prompting for it? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#5002 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACBdWM-ZdFlvP5UgBZvwlLmbt5I8NemSks5tBuNUgaJpZM4QsNd3> .

[stijndepestel]

Is there an update on this? I want to use yarn in our CI/CD environment since it is faster than npm, however, without this option working we cannot use yarn to automate our release/publish mechanism.

[bestander]

The quickest way to get this in is to send a PR. The code is quite simple

…

On Tue, Feb 13, 2018 at 11:39 PM Stijn De Pestel ***@***.***> wrote: Is there an update on this? I want to use yarn in our CI/CD environment since it is faster than npm, however, without this option working we cannot use yarn to automate our release/publish mechanism. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#5002 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACBdWPO6_5_0rGJZfiHuUAAHTR9i5hnmks5tUo2sgaJpZM4QsNd3> .

[iansu]

I made a PR for this a couple of months ago: #5108

[dmerejkowsky]

@stijndepestel

I want to use yarn in our CI/CD environment since it is faster than npm, however, without this option working we cannot use yarn to automate our release/publish mechanism.

At work we have fully automated CI/CD and we use yarn for everything except the last call to npm publish.

it works quite well :)