Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

honor github commit hash #1372

Closed
wants to merge 2 commits into from
Closed

honor github commit hash #1372

wants to merge 2 commits into from

Conversation

shreeve
Copy link
Contributor

@shreeve shreeve commented Oct 22, 2016

Summary

This small commit honors the commit hash for packages hosted on github. This allows references in package.json to use a commit hash like this:

    "cool-util": "niceguy/cool-util#5ea08cb76619f78e17b988ee3acfeba10ce12160"

Test plan

Verified that this small addition pulls in the correct version from github.

@samccone samccone self-assigned this Oct 24, 2016
@samccone samccone mentioned this pull request Oct 24, 2016
Merged
@samccone
Copy link
Member

Thanks for the PR. I have added some tests #1393

@samccone samccone closed this Oct 24, 2016
@shreeve shreeve deleted the honor-github-commit branch October 26, 2016 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@samccone samccone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shreeve @samccone @jamiebuilds