fix-761: do not ignore devDeps that are included as in prod pkg (#761) #1626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When installing with
production
flag thedevDeps
also follow the flow, but are set toignored
. Chances are that aproduction
dependency can be smartly resolved and shared with a devDep. If this is the case make sure this package also gets set toUSED
when being included, so it won't be ignored later.This solves at least:
yarn install --production
doesn't install correct dependencies #761Test plan
npm run test
should not give errors and contain a new use-case for these cases.Extracted & tested use-case from the issue:
Should resolve and give the correct dependencies: