Resolve GitHub http urls with hash #1649
Conversation
| @@ -38,6 +38,17 @@ test('getGitHTTPUrl should return the correct git github SSH url', () => { | |||
| expect(GitHubResolver.getGitSSHUrl(fragment)).toBe(expected); | |||
There was a problem hiding this comment.
Why does the test getGitHTTPUrl should return the correct git github SSH url actually run GitHubResolver.getGitSSHUrl?
|
Though judging from https://github.com/yarnpkg/yarn/pull/202/files I'm not even sure |
|
Hm, I have problems reproducing my initial issue. I wasn't able to install |
| @@ -31,7 +31,8 @@ export default class GitHubResolver extends HostedGitResolver { | |||
| } | |||
|
|
|||
| static getGitHTTPUrl(parts: ExplodedFragment): string { | |||
| return `https://${this.hostname}/${parts.user}/${parts.repo}.git`; | |||
| return `https://${this.hostname}/${parts.user}/${parts.repo}.git` + | |||
There was a problem hiding this comment.
import url from 'url';
...
return url.format({
protocol: 'https:',
host: this.hostname,
path: `${parts.user}/${parts.repo}.git`,
hash: parts.hash,
});should be a bit nicer
|
@backflip could you rebase? |
|
If this is still relevant feel free to rebase and reopen |
Summary
We use GitHub http urls with commit hashes. Currently, they aren't properly resolved. #1393 did fix this for SSH urls only.
Test plan
npm testwith a new test to check whether a hash is appended to the resolvedgetGitHTTPUrlurl.