Fix scoped bin paths #2163
Merged
Fix scoped bin paths #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 8, 2016
|
Will this be released in the 0.18 release line? |
|
Sounds safe enough. |
LinusU
pushed a commit
to LinusU/yarn
that referenced
this pull request
Dec 21, 2016
* Add failing tests for bin path normalisation from scoped package name * Add fix for bin normalisation for scoped packages
|
Done 🎉 👉 #2313 |
bestander
pushed a commit
that referenced
this pull request
Dec 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue with normalising string bin entries in package.json for scoped package names (fixes #1885, #2004). The behaviour here is consistent with NPM's approach.
Test plan
Test fixtures have been added that show the expected behaviour.