Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix offline resolution #3311

Merged
merged 1 commit into from
May 4, 2017
Merged

Fix offline resolution #3311

merged 1 commit into from
May 4, 2017

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented May 3, 2017

Summary

Fix #3221

@arcanis arcanis requested a review from bestander May 3, 2017 15:42
@bestander
Copy link
Member

A test with absolute unix path would be awesome ;)

@arcanis
Copy link
Member Author

arcanis commented May 3, 2017

@bestander How would you do it? Adding a marker like %%PATH%% somewhere in the package.json file from the fixture, and replacing it at runtime from within the test?

@bestander
Copy link
Member

This is the example from create-react-app:
yarn add /path/create-react-app/packages/react-scripts/react-scripts-0.9.4.tgz

@bestander
Copy link
Member

Also replacing path in yarn.lock during test could work

@arcanis arcanis force-pushed the offline-resolution-fix branch from f1be296 to c38ddf3 Compare May 4, 2017 11:54
@bestander bestander merged commit 00f6780 into yarnpkg:master May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bestander bestander Awaiting requested review from bestander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arcanis @bestander