Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove unnecessary empty objects from resolver.init calls #3611

Merged
merged 1 commit into from
Jun 9, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion __tests__/commands/install/integration.js
Original file line number Diff line number Diff line change
@@ -144,7 +144,7 @@ test('changes the cache directory when bumping the cache version', async () => {
const lockfile = await Lockfile.fromDirectory(config.cwd);

const resolver = new PackageResolver(config, lockfile);
await resolver.init([{pattern: 'is-array', registry: 'npm'}], {});
await resolver.init([{pattern: 'is-array', registry: 'npm'}]);

const ref = resolver.getManifests()[0]._reference;
const cachePath = config.generateHardModulePath(ref, true);
2 changes: 1 addition & 1 deletion __tests__/package-resolver.js
Original file line number Diff line number Diff line change
@@ -42,7 +42,7 @@ function addTest(pattern, registry = 'npm', init: ?(cacheFolder: string) => Prom
}

const resolver = new PackageResolver(config, lockfile);
await resolver.init([{pattern, registry}], {});
await resolver.init([{pattern, registry}]);

const ref = resolver.getManifests()[0]._reference;
const cachePath = config.generateHardModulePath(ref, true);