-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] update jest and flow #3652
Conversation
:O I'm curious, what makes those tests failing (at least those which fail not because of Flow)? |
I write some bash commands to fix fastly some ripetitve errors, I think in some parts I put some bugs D: I think I will dig further in the next week, in the meantime if someone find something erronous please let me know! |
fe401db
to
95b892e
Compare
eaa18b1
to
9b70e69
Compare
@arcanis @bestander it seems to work. The only BIG issue is that:
It seems that upgrading jest, something related to babel is upgraded as well.. and the polyfill |
…et-node5 and babel-preset-stage-0
ok I finally found why includes does not work with jest and babel-jest jestjs/jest#2755. Also avajs/ava#263 was a very interesting reading :) Now I have the big picture, tomorrow I will open three pull requests to update flow, jest and babel separately :D |
ah TL; DR we should not use includes function in our tests O.o |
Summary
In this pull request I try to update jest and flow. Now they are failing 30 tests, but flow check passes (I fixed almost 100 failing checks).
Pain points:
Test plan
The same tests in place, maybe I will add other tests for some edge cases.
Questions
yarn upgrade-interactive
? I think It could be an interesting feature..Feedbacks are welcome :)
EDIT: I tried to update flow because when I try to refactor
package-request
I found that there are some flow errors in integrity-checker, I think the old version of flow has some problems (obviously :D).