Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] update jest and flow #3652

Closed
wants to merge 14 commits into from
Closed

Conversation

voxsim
Copy link
Contributor

@voxsim voxsim commented Jun 16, 2017

Summary
In this pull request I try to update jest and flow. Now they are failing 30 tests, but flow check passes (I fixed almost 100 failing checks).

Pain points:

Test plan
The same tests in place, maybe I will add other tests for some edge cases.

Questions

  • Is there any way to upgrade one minor at time with yarn upgrade-interactive? I think It could be an interesting feature..

Feedbacks are welcome :)

EDIT: I tried to update flow because when I try to refactor package-request I found that there are some flow errors in integrity-checker, I think the old version of flow has some problems (obviously :D).

@arcanis
Copy link
Member

arcanis commented Jun 19, 2017

:O I'm curious, what makes those tests failing (at least those which fail not because of Flow)?

@voxsim
Copy link
Contributor Author

voxsim commented Jun 19, 2017

I write some bash commands to fix fastly some ripetitve errors, I think in some parts I put some bugs D: I think I will dig further in the next week, in the meantime if someone find something erronous please let me know!

@voxsim voxsim force-pushed the update-jest-and-flow branch from fe401db to 95b892e Compare June 20, 2017 21:24
@voxsim voxsim force-pushed the update-jest-and-flow branch from eaa18b1 to 9b70e69 Compare June 21, 2017 11:26
@voxsim
Copy link
Contributor Author

voxsim commented Jun 21, 2017

@arcanis @bestander it seems to work. The only BIG issue is that:

****.includes is not a function

It seems that upgrading jest, something related to babel is upgraded as well.. and the polyfill Array.includes in node 4 stops to work or maybe it is not included correctly.
Now I am doing some experiments to understand why it doesn't work. My last chance is to revert jest and I hope everything will work like before.
I also noticed that we are using many deprecated babel packages, maybe someone who knows Babel better can help me in another pull request O.o

@voxsim
Copy link
Contributor Author

voxsim commented Jun 21, 2017

ok I finally found why includes does not work with jest and babel-jest jestjs/jest#2755.

Also avajs/ava#263 was a very interesting reading :)

Now I have the big picture, tomorrow I will open three pull requests to update flow, jest and babel separately :D

@voxsim voxsim closed this Jun 21, 2017
@voxsim
Copy link
Contributor Author

voxsim commented Jun 21, 2017

ah TL; DR we should not use includes function in our tests O.o

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants