Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selective versions resolutions #3868

Closed

Conversation

victornoel
Copy link
Contributor

Summary

This is an implementation for yarnpkg/rfcs#68.

For now there is only failing tests to start things up. I'm not sure I will be able to implement it so at least I will provide the tests for someone more knowledgeable of yarn codebase to focus on the implementation itself :)

@bestander @arcanis

Test plan

There was an RFC made and discussed.
We should at least add those unit tests:

  • non-exact versioning
  • I'm not sure how to do that if I am to use local file-based dependencies
  • previously flattened project
  • ...

@bestander
Copy link
Member

Great start, @victornoel.
Would be so great to get you involved in implementation.
What can I do to motivate you? :)

It is a good idea to start with tests, make them skipped once you are happy that you the coverage is good and we'll merge it to make the PR not stalling.
In the next iteration someone could implement the actual fix to package-resolver

@BYK
Copy link
Member

BYK commented Jul 25, 2017

@victornoel hi! Need anything from us?

@victornoel
Copy link
Contributor Author

@BYK sorry, I have been a bit under the water lately and I will be AFK for a month, so it's either on hold or someone else can start working on it :)

I won't handle the implementation though, so if someone is interested, it's possible to start from the existing acceptance tests and the RFC. If not, I will try to make more acceptance tests in a month.

@BYK
Copy link
Member

BYK commented Aug 2, 2017

@BYK sorry, I have been a bit under the water lately and I will be AFK for a month, so it's either on hold or someone else can start working on it :)

No worries, thanks for the update :) I think @kaylieEB is on this now.

@BYK BYK assigned kaylie-alexa and unassigned BYK Aug 2, 2017
@BYK
Copy link
Member

BYK commented Aug 7, 2017

Closing this in favor of #4105. LMK if you think that's a mistake.

@BYK BYK closed this Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants