Prevent --check-files from crossing symlinks #3931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaylie-alexa
approved these changes
Jul 13, 2017
arcanis
force-pushed
the
link-check-files
branch
from
6ff4c5f
to
581113c
Compare
BYK
approved these changes
Jul 14, 2017
arcanis
added a commit
that referenced
this pull request
Jul 19, 2017
* Prevent --check-files from crossing symlinks * Update integration.js * Lints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix an issue where using --check-files together with symlinks was causing Yarn to crash if the symlink wasn't a valid target. This fix prevent going through all links altogether. It also affects links created via
yarn link, but I don't think that's a problem - we probably shouldn't include inside the integrity file the files that belong to another part of the filesystem.Test plan
Adds a test.