Warn when a shrinkwrap exists in the cwd #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiebuilds
approved these changes
Sep 21, 2016
46 tasks
Turbo87
reviewed
Oct 17, 2016
| @@ -199,6 +199,11 @@ export class Install { | |||
| // remove integrity hash to make this operation atomic | |||
| await fs.unlink(match.loc); | |||
|
|
|||
| // warn if we have a shrinkwrap | |||
| if (await fs.exists(path.join(this.config.cwd, 'npm-shrinkwrap.json'))) { | |||
| this.reporter.error(this.reporter.lang('shrinkwrapWarning')); | |||
There was a problem hiding this comment.
shouldn't this be reporter.warn(...) instead? I'd expect error only when the issue is not recoverable.
|
This also relates to #396 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #396.