Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arguement -v is version not verbose #4362

Merged
merged 1 commit into from
Sep 8, 2017
Merged

arguement -v is version not verbose #4362

merged 1 commit into from
Sep 8, 2017

Conversation

vafada
Copy link
Contributor

@vafada vafada commented Sep 8, 2017 •
edited by BYK
Loading

Summary

Currently running yarn -v displays the yarn version number but yarn -h says otherwise:

$ yarn -h

  Usage: yarn [command] [flags]

  Options:

    -h, --help                          output usage information
    --version                           output the version number
    -v, --verbose                       output verbose messages on internal operations

$ yarn -v
1.0.1

this PR fixes yarn -h to use -v as version number. Output of yarn -h with this PR:

$ ./bin/yarn -h

  Usage: yarn [command] [flags]

  Options:

    -h, --help                          output usage information
    -v, --version                       output the version number
    --verbose                           output verbose messages on internal operations

@buildsize
Copy link

buildsize bot commented Sep 8, 2017

This change will decrease the build size from 9.51 MB to 9.51 MB, a decrease of 307 bytes (0%)

File name Previous Size New Size Change
yarn-[version].noarch.rpm 819.53 KB 819.46 KB -71 bytes (0%)
yarn-[version].js 3.62 MB 3.62 MB -14 bytes (0%)
yarn-legacy-[version].js 3.67 MB 3.67 MB -14 bytes (0%)
yarn-v[version].tar.gz 823.67 KB 823.64 KB -32 bytes (0%)
yarn_[version]all.deb 626.43 KB 626.26 KB -176 bytes (0%)

1 similar comment
@buildsize
Copy link

buildsize bot commented Sep 8, 2017

This change will decrease the build size from 9.51 MB to 9.51 MB, a decrease of 307 bytes (0%)

File name Previous Size New Size Change
yarn-[version].noarch.rpm 819.53 KB 819.46 KB -71 bytes (0%)
yarn-[version].js 3.62 MB 3.62 MB -14 bytes (0%)
yarn-legacy-[version].js 3.67 MB 3.67 MB -14 bytes (0%)
yarn-v[version].tar.gz 823.67 KB 823.64 KB -32 bytes (0%)
yarn_[version]all.deb 626.43 KB 626.26 KB -176 bytes (0%)

BYK
BYK approved these changes Sep 8, 2017
View reviewed changes
Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks a lot!

@BYK BYK merged commit b33fe26 into yarnpkg:master Sep 8, 2017
@BYK BYK added this to the 1.0.2 milestone Sep 12, 2017
joaolucasl pushed a commit to joaolucasl/yarn that referenced this pull request Oct 27, 2017
@vafada @joaolucasl
Fix: argument -v is for version not verbose (yarnpkg#4362)
2298efc 
**Summary**

Currently running `yarn -v` displays the yarn version number but `yarn -h` says otherwise:

```
$ yarn -h

  Usage: yarn [command] [flags]

  Options:

    -h, --help                          output usage information
    --version                           output the version number
    -v, --verbose                       output verbose messages on internal operations

$ yarn -v
1.0.1

```

this PR fixes `yarn -h` to use `-v` as version number. Output of `yarn -h` with this PR:

```
$ ./bin/yarn -h

  Usage: yarn [command] [flags]

  Options:

    -h, --help                          output usage information
    -v, --version                       output the version number
    --verbose                           output verbose messages on internal operations

```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BYK BYK BYK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@vafada @BYK