Fix: Handle null versions in package.json
#4461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** Fixes #4429. Apparently there's an advice on the internet to use `null` as the package version to install the latest version and even worse, some people are using this. This patch makes sure the version is at least a string (albeit an empty one) when fixing the manifest. **Test plan** Added new integration test.
|
This change will increase the build size from 9.69 MB to 9.69 MB, an increase of 224 bytes (0%)
|
|
typeof null is "object"! |
|
@bestander or just use flow? 😃 |
joaolucasl
pushed a commit
to joaolucasl/yarn
that referenced
this pull request
Oct 27, 2017
**Summary** Fixes yarnpkg#4429. Apparently there's an advice on the internet to use `null` as the package version to install the latest version and even worse, some people are using this. This patch makes sure the version is at least a string (albeit an empty one) when fixing the manifest. **Test plan** Added new integration test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4429. Apparently there's an advice on the internet to use
nullas the package version to install the latest and even worse,some people are actually doing this. This patch makes sure the
version is at least a string (albeit an empty one) when fixing the
manifest.
Test plan
Added new integration test.