Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for pattern not working with upgrade #5662

Merged
merged 1 commit into from
Apr 12, 2018

Conversation

philquinn
Copy link
Contributor

Summary

Fix for #5660

Before it needed to have package argument to enter the block to filter the deps. Now it will do it if either a package is given or a --pattern is given.

Test plan

Corrected my incorrectly created tests.
Also is-negative-zero would not update as there is no new version which would be found in a caret. So changed that to array-union which has a version 1.0.2

@rally25rs rally25rs merged commit 036a246 into yarnpkg:master Apr 12, 2018
@rally25rs
Copy link
Contributor

Thanks for the quick fix! 👍

@philquinn
Copy link
Contributor Author

no problem @rally25rs . Thanks for merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants