chore(request): Add an unfiltered option to getting full responses from npm
#5667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** Follow up to #5593. Looks like we need to send `Accept: application/json` header with most of the registry requests so this patch adds it by default and removes the ad-hoc headers from info and owner commands. **Test plan** Existing tests should pass.
arcanis
previously approved these changes
Apr 13, 2018
|
Seems like it breaks the |
BYK
changed the title
unfiltered option to getting full responses from npm
BYK
dismissed
arcanis’s stale review
@arcanis - I've changed the PR quite a bit so I'd appreciate another review.
rally25rs
approved these changes
Apr 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #5593. Looks like we use an npm-specific request header to reduce the bandwidth. That said, for some commands, we need the full responses, which was achieved by setting the
Accept: application/jsonheader manually. This patch introduces a more descriptive request option,unfilteredto standardize this usage.See https://github.com/npm/npm-registry-client#requests for more info.
Test plan
Existing tests should pass.