test: Fix failing tests on master #5687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** We had an integration test relying on a specific version of a package without coding that version into the test. This PR fixes that and fixes tests failing on master as of now. **Test plan** CI should pass.
rally25rs
reviewed
Apr 17, 2018
BYK
changed the title
arcanis
approved these changes
Apr 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We had an integration test relying on a specific version of a package without coding that version
into the test.
We also had some tests using snapshots with
test.concurrentwhich are not safe to use per jestjs/jest#1630 (comment). These were randomly failing, mostly on AppVeyor.This PR fixes tests failing on master as of now.
Test plan
CI should pass.