test(init): Fix flaky init test which used snapshots w/ concurrent #5700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** Snapshots should not be used with `test.concurrent`. This PR fixes a flaky test which was doing exactly this. **Test plan** CI should pass.
imsnif
reviewed
Apr 19, 2018
There was a problem hiding this comment.
@BYK - LGTM. Just a thought though, what about removing the concurrent from the above test as well for consistency?
yarn/__tests__/commands/init.js
Line 15 in 45ee820
Locally this works for me, wanted your input before pushing.
EDIT: scratch that. I didn't notice that above test did not use snapshots. My bad. :)
imsnif
approved these changes
Apr 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Snapshots should not be used with
test.concurrent. This PR fixes aflaky test which was doing exactly this.
Test plan
CI should pass.