fix: Removes usage of deprecated Buffer constructor. (#5477)

[aduh95]

Summary

Fixes #5477 and #5704.

Remove usager of deprecated Bufferconstructor to avoid ugly warnings on Node 10.

Test plan

Existing test should pass.

[fungilation]

Please merge. Node 10 is released and I keep seeing warning like:

(node:35805) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

[BYK]

Thanks a ton for doing this!

[BYK]

lol

[felixrabe]

Thanks!

As a workaround before the next release of Yarn, I've created a ~/bin/node script that comes before (Homebrew-installed) /usr/local/bin/node in my $PATH:

#!/bin/bash

/usr/local/bin/node --no-deprecation "$@"

[tusharmath]

Has this been release? If not then when is the next planned release?

[gausam]

Great work on having this out of the way. Any news on a release with the fix? Hit pretty hard, and as more people update their npm the cats will rain harder.

[BYK]

@tusharmath @samtheson you can follow #5769 for the final Node 10 fix. We'll release a new version as soon as we merge that.