Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused constants #5830

Merged
merged 2 commits into from
May 23, 2018
Merged

Conversation

ohbarye
Copy link
Contributor

@ohbarye ohbarye commented May 16, 2018

Summary

I just found that those constants are not used anywhere, then just removed them.

  • SELF_UPDATE_TARBALL_URL : it may be remain when removing self-update
  • SELF_UPDATE_DOWNLOAD_FOLDER : it may be remain when removing self-update
  • ACCESS_FILENAME : this seems to have never been used

Please feel free to close this if you won't need this kind of nitpicking pull request. :P

Test plan

Let me put search results.

~/.g/g/o/yarn ❯❯❯ ag (SELF_UPDATE_TARBALL_URL|SELF_UPDATE_DOWNLOAD_FOLDER|ACCESS_FILENAME) .                                                        ⏎ remove-unused-constants ✱
src/constants.js
26:export const SELF_UPDATE_TARBALL_URL = 'https://yarnpkg.com/latest.tar.gz';
27:export const SELF_UPDATE_DOWNLOAD_FOLDER = 'updates';
89:export const ACCESS_FILENAME = '.yarn-access';
~/.g/g/o/yarn ❯❯❯

@BYK BYK changed the title Remove unused constants chore: Remove unused constants May 23, 2018
Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@BYK BYK merged commit b3bce08 into yarnpkg:master May 23, 2018
@ohbarye ohbarye deleted the remove-unused-constants branch May 23, 2018 15:17
@ohbarye
Copy link
Contributor Author

ohbarye commented May 23, 2018

Thanks for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants