Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I just found that those constants are not used anywhere, then just removed them.
SELF_UPDATE_TARBALL_URL
: it may be remain when removingself-update
SELF_UPDATE_DOWNLOAD_FOLDER
: it may be remain when removingself-update
ACCESS_FILENAME
: this seems to have never been usedPlease feel free to close this if you won't need this kind of nitpicking pull request. :P
Test plan
Let me put search results.