fix(util/semver): handle invalid versions in satisfiesWithPrereleases #6019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greysteil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where if invalid SemVer versions were present on a registry, Yarn wouldn't be able to update that dependency.
It's (very) rare for invalid SemVer versions to be present on npm registries, but it's possible, particularly for private registries which may or may not have checks present when versions are pushed.
Before this patch, the presence of any such versions would causes a resolution-ending
TypeError: Invalid Versionwhen determining which version to update that dependency to. After this patch, invalid versions on the registry will be quietly ignored.Test plan
I've added a test which fails if the code change here isn't applied.