Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yarn.ps1, fixes #6092 (bad Ctrl C behavior) #6093

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Add yarn.ps1, fixes #6092 (bad Ctrl C behavior) #6093

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions bin/yarn.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
function Get-ScriptDirectory {
$Invocation = (Get-Variable MyInvocation -Scope 1).Value
Split-Path $Invocation.MyCommand.Path
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any difference between the output of this function and $PSScriptRoot?

Copy link
Member

@Gudahtt Gudahtt Aug 22, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$PSScriptRoot may not have been considered because it was introduced in PowerShell 3. It would not work for users of older versions of PowerShell.

Edit: Sorry, forgot to answer your question. No, I don't believe there is any difference.

Copy link
Contributor Author

@mikemaccana mikemaccana Aug 22, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the author $PSScriptRoot wasn't considered because I just learnt about it from @felixfbecker. 😀 Do we want to support Windows 7 default (Powershell 2) or not though?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If $PSScriptRoot was introduced in PS 3 that would mean it is not supported in Windows 7 - I don't know what the support policy is here from yarn / NodeJS?


node "$(Get-ScriptDirectory)/yarn.js" $args