Changed isValidLicense Check

[irrationalRock]

Summary
This PR fixes #6009.

It no longer throws an error when given " ".

Motivation

Yarn would not allow you to install a package if it had " " in it.

Test plan
When running yarn add mongoose-post-find, it now runs without producing an error.

[Gudahtt]

I think you're on the right track with using a try...catch block around validateLicense, but there are a few problems here still.

The original call to validateLicense is still there, and would still throw an exception when called. Instead of repeating that call, the result of the one inside the try...catch should be stored in a variable. Then you can reference that variable below when checking validForNewPackages.

The catch block also shouldn't be empty. If the validateLicense function throws an exception, it likely means the license isn't valid. That should return false, so that the warning message appears.

[Gudahtt]

Also, this bug was also just fixed in version 3.0.4 of validate-npm-package-license. Updating to that version instead would fix the problem as well.

[irrationalRock]

Thanks for the advice. I updated the package and it no longer throws the error.

[Gudahtt]

Could you remove these changes in src/util/normalize-manifest/util.js now? They should no longer be needed.

[Gudahtt]

Thanks! The last thing that comes to mind is that you updated the yarn.lock file to point at 3.0.4, but not the package.json file. That should be updated as well, to ensure it stays above or at that minimum version.

[irrationalRock]

Thanks for the help. I updated the yarn.lock and package.json file.

[Gudahtt]

That ^ should stay there. We don't want to pin this dependency and prevent future updates.

[irrationalRock]

Thanks for the suggestion. I changed it to ^.

[arcanis]

Thanks 💯